Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a PrismJS React and HTML tutorial link #3190

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

catchsrinivas
Copy link
Contributor

Adding a PrismJS React and HTML tutorial link

Adding a PrismJS React and HTML tutorial link
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

No JS Changes

Generated by 🚫 dangerJS against ce5d88f

@RunDevelopment
Copy link
Member

THanks for the article @catchsrinivas!

Unfortunately, I can't accept it as is since it contains a few mistakes:

  1. "How to add Prism.js syntax highlighting to any website? > Step 4:"

    The shown code blocks are a little wrong. This is HTML (not React), so the spaces between <pre> and <code> will be displayed on the page. In plain HTML, there must not be spaces and/or line breaks between the opening and closing <pre> and <code> tags. (It doesn't matter in React because React will automatically remove any spaces and line breaks.)

  2. "Get PrismJS working in React"

    The React section isn't correct. Since you aren't using the babel plugin, import Prism from "prismjs" will just import a Prism instance with HTML, CSS, and JS loaded. Nothing else. Importing other languages isn't easy without the babel plugin.

    Also, selecting other languages before downloading the CSS won't do anything because languages don't have associated CSS. Also also, downloading CSS isn't necessary anyway with the babel plugin.

@catchsrinivas
Copy link
Contributor Author

catchsrinivas commented Nov 10, 2021

@RunDevelopment Thanks for the feedback. I have made the necessary changes in the article for both HTML and React tutorials and also added a sample working demo project in github as a reference. Could you please review and approve?

@RunDevelopment RunDevelopment merged commit 0ecdbdc into PrismJS:master Nov 10, 2021
@RunDevelopment
Copy link
Member

Thank you for contributing @catchsrinivas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants